Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ads] Fix NTP media type P3A metrics when modified from Rewards page (uplift to 1.70.x) #25587

Closed
wants to merge 1 commit into from
Closed

[ads] Fix NTP media type P3A metrics when modified from Rewards page (uplift to 1.70.x) #25587

wants to merge 1 commit into from
+52 −26

Conversation

brave-builds
Copy link
Collaborator

Uplift of #25558
Resolves brave/brave-browser#41026

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner September 16, 2024 16:41
@brave-builds brave-builds added this to the 1.70.x - Release milestone Sep 16, 2024
@brave-builds brave-builds self-assigned this Sep 16, 2024
kjozwiak
kjozwiak reviewed Sep 16, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing the above as per the discussion with @aseren & @DJAndries. We'll uplift the above fix into 1.71.x via #25586 and let it ride the trains through 1.71.x.

@kjozwiak kjozwiak closed this Sep 16, 2024
@kjozwiak kjozwiak deleted the pr25558_issues/41026_1.70.x branch September 16, 2024 16:59
@kjozwiak kjozwiak removed this from the 1.70.x - Release milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak left review comments

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @kjozwiak